aboutsummaryrefslogtreecommitdiff
diff options
context:
space:
mode:
authorMichael Davis2023-07-25 21:11:11 +0000
committerBlaž Hrastnik2023-07-27 02:50:19 +0000
commitf0b877e2588306882f71eaad45a3f3e604885a34 (patch)
treef7c03335cc522b2e8558775dba8a44b5d347af6b
parent0dc3753eb2a1af296f5faffaf9c3d29bceb5a37f (diff)
Tune regex highlights for usage in prompts
Since regex is almost always injected into other languages, `pattern_character`s will inherit the highlight for the structure that injects them (for example `/foo/` in JavaScript or `~r/foo/` in Elixir). This removes the string highlight when used in the prompt. We also add `ERROR` node highlighting so that errors in regex syntax appear in the prompt. This resolves a TODO in the `regex_prompt` function about highlighting errors in the regex.
-rw-r--r--helix-term/src/ui/mod.rs3
-rw-r--r--runtime/queries/regex/highlights.scm2
2 files changed, 1 insertions, 4 deletions
diff --git a/helix-term/src/ui/mod.rs b/helix-term/src/ui/mod.rs
index 8ca1b131..215794e3 100644
--- a/helix-term/src/ui/mod.rs
+++ b/helix-term/src/ui/mod.rs
@@ -142,9 +142,6 @@ pub fn regex_prompt(
};
cx.jobs.callback(callback);
- } else {
- // Update
- // TODO: mark command line as error
}
}
}
diff --git a/runtime/queries/regex/highlights.scm b/runtime/queries/regex/highlights.scm
index cad08f40..302cc6b3 100644
--- a/runtime/queries/regex/highlights.scm
+++ b/runtime/queries/regex/highlights.scm
@@ -50,4 +50,4 @@
])
(class_character) @constant.character
-(pattern_character) @string
+(ERROR) @error