aboutsummaryrefslogtreecommitdiff
diff options
context:
space:
mode:
authorGokul Soumya2021-11-08 00:52:51 +0000
committerGitHub2021-11-08 00:52:51 +0000
commite0e227d172697c0d3c418704fd20e780ee1a1032 (patch)
tree4b9b8d946cd6f908e8286f236c3e52429b82891e
parent4304b52ff86f829115cb89b20160b4f80dbb3dbd (diff)
Touch up docs for adding new language (#1002)
-rw-r--r--book/src/guides/adding_languages.md23
-rw-r--r--book/src/guides/textobject.md2
2 files changed, 16 insertions, 9 deletions
diff --git a/book/src/guides/adding_languages.md b/book/src/guides/adding_languages.md
index 00902876..c606f8fc 100644
--- a/book/src/guides/adding_languages.md
+++ b/book/src/guides/adding_languages.md
@@ -2,13 +2,14 @@
## Submodules
-To add a new langauge, you should first add a tree-sitter submodule. To do this, you can run the command
+To add a new langauge, you should first add a tree-sitter submodule. To do this,
+you can run the command
```sh
-$ git submodule add -f <repository> helix-syntax/languages/tree-sitter-<name>
+git submodule add -f <repository> helix-syntax/languages/tree-sitter-<name>
```
For example, to add tree-sitter-ocaml you would run
```sh
-$ git submodule add -f https://github.com/tree-sitter/tree-sitter-ocaml helix-syntax/languages/tree-sitter-ocaml
+git submodule add -f https://github.com/tree-sitter/tree-sitter-ocaml helix-syntax/languages/tree-sitter-ocaml
```
Make sure the submodule is shallow by doing
```sh
@@ -19,7 +20,10 @@ or you can manually add `shallow = true` to `.gitmodules`.
## languages.toml
-Next, you need to add the language to the `languages.toml` found in the root of the repository; this `languages.toml` file is included at compilation time, and is distinct from the `language.toml` file in the user's [configuration directory](../configuration.md).
+Next, you need to add the language to the [`languages.toml`][languages.toml] found in the root of
+the repository; this `languages.toml` file is included at compilation time, and
+is distinct from the `language.toml` file in the user's [configuration
+directory](../configuration.md).
These are the available keys and descriptions for the file.
@@ -27,7 +31,7 @@ These are the available keys and descriptions for the file.
| ---- | ----------- |
| name | The name of the language |
| scope | A string like `source.js` that identifies the language. Currently, we strive to match the scope names used by popular TextMate grammars and by the Linguist library. Usually `source.<name>` or `text.<name>` in case of markup languages |
-| injection-regex | regex pattern that will be tested against a language name in order to determine whether this language should be used for a potential language injection site. [link](https://tree-sitter.github.io/tree-sitter/syntax-highlighting#language-injection) |
+| injection-regex | regex pattern that will be tested against a language name in order to determine whether this language should be used for a potential [language injection][treesitter-language-injection] site. |
| file-types | The filetypes of the language, for example `["yml", "yaml"]` |
| roots | A set of marker files to look for when trying to find the workspace root. For example `Cargo.lock`, `yarn.lock` |
| auto-format | Whether to autoformat this language when saving |
@@ -42,11 +46,14 @@ For a language to have syntax-highlighting and indentation among other things, y
## Common Issues
- If you get errors when building after switching branches, you may have to remove or update tree-sitter submodules. You can update submodules by running
-```sh
-$ git submodule sync; git submodule update --init
-```
+ ```sh
+ git submodule sync; git submodule update --init
+ ```
- Make sure to not use the `--remote` flag. To remove submodules look inside the `.gitmodules` and remove directories that are not present inside of it.
- If a parser is segfaulting or you want to remove the parser, make sure to remove the submodule *and* the compiled parser in `runtime/grammar/<name>.so`
- The indents query is `indents.toml`, *not* `indents.scm`. See [this](https://github.com/helix-editor/helix/issues/114) issue for more information.
+
+[treesitter-language-injection]: https://tree-sitter.github.io/tree-sitter/syntax-highlighting#language-injection
+[languages.toml]: https://github.com/helix-editor/helix/blob/master/languages.toml
diff --git a/book/src/guides/textobject.md b/book/src/guides/textobject.md
index 50b3b574..dd726b7c 100644
--- a/book/src/guides/textobject.md
+++ b/book/src/guides/textobject.md
@@ -5,7 +5,7 @@ require an accompanying tree-sitter grammar and a `textobjects.scm` query file
to work properly. Tree-sitter allows us to query the source code syntax tree
and capture specific parts of it. The queries are written in a lisp dialect.
More information on how to write queries can be found in the [official tree-sitter
-documentation](tree-sitter-queries).
+documentation][tree-sitter-queries].
Query files should be placed in `runtime/queries/{language}/textobjects.scm`
when contributing. Note that to test the query files locally you should put