From 45ce1ebdb604ae8b044a012f2933e6a42574430a Mon Sep 17 00:00:00 2001 From: Michael Davis Date: Fri, 17 Jun 2022 22:59:57 -0500 Subject: embed jsonrpc types from jsonrpc-core crate (#2801) We should not depend on jsonrpc-core anymore: * The project just announced it's no longer actively maintained[^1], preferring their new implementation in `jsonrpsee`. * The types are too strict: we would benefit from removing some `#[serde(deny_unknown_fields)]` annotations to allow language servers that disrespect the spec[^2]. * We don't use much of the project. Just the types out of core. These are easy to embed directly into the `helix-lsp` crate. [^1]: https://github.com/paritytech/jsonrpc/pull/674 [^2]: https://github.com/helix-editor/helix/issues/2786--- helix-lsp/Cargo.toml | 1 - 1 file changed, 1 deletion(-) (limited to 'helix-lsp/Cargo.toml') diff --git a/helix-lsp/Cargo.toml b/helix-lsp/Cargo.toml index fb36758f..b7d26662 100644 --- a/helix-lsp/Cargo.toml +++ b/helix-lsp/Cargo.toml @@ -17,7 +17,6 @@ helix-core = { version = "0.6", path = "../helix-core" } anyhow = "1.0" futures-executor = "0.3" futures-util = { version = "0.3", features = ["std", "async-await"], default-features = false } -jsonrpc-core = { version = "18.0", default-features = false } # don't pull in all of futures log = "0.4" lsp-types = { version = "0.93", features = ["proposed"] } serde = { version = "1.0", features = ["derive"] } -- cgit v1.2.3-70-g09d2