From 9fae4b81189e9ba02718595a09840535f6fb558b Mon Sep 17 00:00:00 2001
From: GabrielDertoni
Date: Sun, 9 Oct 2022 00:23:02 -0300
Subject: fix: terminal freezing on `shell_insert_output`

This bug occurs on `shell_insert_output` and `shell_append_output`
commands.

The previous implementation would create a child process using the Rust
stdlib's `Command` builder. However, when nothing should be piped in
from the editor, the default value for `stdin` would be used. According
to the Rust stdlib documentation that is `Stdio::inherit` which will
make the child process inherit the parent process' stdin. This would
cause the terminal to freeze.

This change will set the child process' stdin to `Stdio::null` whenever
it doesn't pipe it. In the `if` statement where this change was made
there was an extra condition for windows that I am not sure if would
require some special treatment.
---
 helix-term/src/commands.rs | 2 ++
 1 file changed, 2 insertions(+)

(limited to 'helix-term/src/commands.rs')

diff --git a/helix-term/src/commands.rs b/helix-term/src/commands.rs
index 468e9814..69870a27 100644
--- a/helix-term/src/commands.rs
+++ b/helix-term/src/commands.rs
@@ -4665,6 +4665,8 @@ fn shell_impl(
 
     if input.is_some() || cfg!(windows) {
         process.stdin(Stdio::piped());
+    } else {
+        process.stdin(Stdio::null());
     }
 
     let mut process = match process.spawn() {
-- 
cgit v1.2.3-70-g09d2