From ffdc2f179334de82383670faed68acfc54317f55 Mon Sep 17 00:00:00 2001 From: Michael Davis Date: Fri, 1 Apr 2022 20:07:35 -0500 Subject: separate JSX queries from javascript (#1921) It looks like a24fb17b2a978d3165bd6304e9edd69bddb6dd82 (and 855e438f55cb278de8203ac4911561c4c7ad656c) broke the typescript highlights because typescript ; inherits: javascript but it doesn't have those named nodes in its grammar. So instead we can separate out JSX into its own language and copy over everything from javascript and supplement it with the new JSX highlights. Luckily there isn't too much duplication, just the language configuration parts - we can re-use the parser with the languages.toml `grammar` key and most of the queries with `inherits`.--- runtime/queries/jsx/highlights.scm | 27 +++++++++++++++++++++++++++ runtime/queries/jsx/indents.scm | 1 + runtime/queries/jsx/injections.scm | 1 + runtime/queries/jsx/locals.scm | 1 + 4 files changed, 30 insertions(+) create mode 100644 runtime/queries/jsx/highlights.scm create mode 100644 runtime/queries/jsx/indents.scm create mode 100644 runtime/queries/jsx/injections.scm create mode 100644 runtime/queries/jsx/locals.scm (limited to 'runtime/queries/jsx') diff --git a/runtime/queries/jsx/highlights.scm b/runtime/queries/jsx/highlights.scm new file mode 100644 index 00000000..9be5f517 --- /dev/null +++ b/runtime/queries/jsx/highlights.scm @@ -0,0 +1,27 @@ +; inherits: javascript + +; Highlight component names differently +(jsx_opening_element ((identifier) @constructor + (#match? @constructor "^[A-Z]"))) + +; Handle the dot operator effectively - +(jsx_opening_element ((nested_identifier (identifier) @tag (identifier) @constructor))) + +(jsx_closing_element ((identifier) @constructor + (#match? @constructor "^[A-Z]"))) + +; Handle the dot operator effectively - +(jsx_closing_element ((nested_identifier (identifier) @tag (identifier) @constructor))) + +(jsx_self_closing_element ((identifier) @constructor + (#match? @constructor "^[A-Z]"))) + +; Handle the dot operator effectively - +(jsx_self_closing_element ((nested_identifier (identifier) @tag (identifier) @constructor))) + +; TODO: also tag @punctuation.delimiter? + +(jsx_opening_element (identifier) @tag) +(jsx_closing_element (identifier) @tag) +(jsx_self_closing_element (identifier) @tag) +(jsx_attribute (property_identifier) @variable.other.member) diff --git a/runtime/queries/jsx/indents.scm b/runtime/queries/jsx/indents.scm new file mode 100644 index 00000000..ff0ddfac --- /dev/null +++ b/runtime/queries/jsx/indents.scm @@ -0,0 +1 @@ +; inherits: javascript diff --git a/runtime/queries/jsx/injections.scm b/runtime/queries/jsx/injections.scm new file mode 100644 index 00000000..ff0ddfac --- /dev/null +++ b/runtime/queries/jsx/injections.scm @@ -0,0 +1 @@ +; inherits: javascript diff --git a/runtime/queries/jsx/locals.scm b/runtime/queries/jsx/locals.scm new file mode 100644 index 00000000..ff0ddfac --- /dev/null +++ b/runtime/queries/jsx/locals.scm @@ -0,0 +1 @@ +; inherits: javascript -- cgit v1.2.3-70-g09d2