From 71551d395b4e47804df2d8ecea99e34dbbf16157 Mon Sep 17 00:00:00 2001 From: Philipp Mildenberger Date: Mon, 23 May 2022 18:10:48 +0200 Subject: Adds support for multiple language servers per language. Language Servers are now configured in a separate table in `languages.toml`: ```toml [langauge-server.mylang-lsp] command = "mylang-lsp" args = ["--stdio"] config = { provideFormatter = true } [language-server.efm-lsp-prettier] command = "efm-langserver" [language-server.efm-lsp-prettier.config] documentFormatting = true languages = { typescript = [ { formatCommand ="prettier --stdin-filepath ${INPUT}", formatStdin = true } ] } ``` The language server for a language is configured like this (`typescript-language-server` is configured by default): ```toml [[language]] name = "typescript" language-servers = [ { name = "efm-lsp-prettier", only-features = [ "format" ] }, "typescript-language-server" ] ``` or equivalent: ```toml [[language]] name = "typescript" language-servers = [ { name = "typescript-language-server", except-features = [ "format" ] }, "efm-lsp-prettier" ] ``` Each requested LSP feature is priorized in the order of the `language-servers` array. For example the first `goto-definition` supported language server (in this case `typescript-language-server`) will be taken for the relevant LSP request (command `goto_definition`). If no `except-features` or `only-features` is given all features for the language server are enabled, as long as the language server supports these. If it doesn't the next language server which supports the feature is tried. The list of supported features are: - `format` - `goto-definition` - `goto-declaration` - `goto-type-definition` - `goto-reference` - `goto-implementation` - `signature-help` - `hover` - `document-highlight` - `completion` - `code-action` - `workspace-command` - `document-symbols` - `workspace-symbols` - `diagnostics` - `rename-symbol` - `inlay-hints` Another side-effect/difference that comes with this PR, is that only one language server instance is started if different languages use the same language server. --- xtask/src/docgen.rs | 11 ++++++----- 1 file changed, 6 insertions(+), 5 deletions(-) (limited to 'xtask/src/docgen.rs') diff --git a/xtask/src/docgen.rs b/xtask/src/docgen.rs index 473882f3..3bd0592e 100644 --- a/xtask/src/docgen.rs +++ b/xtask/src/docgen.rs @@ -96,11 +96,12 @@ pub fn lang_features() -> Result { ); } row.push( - lc.language_server - .as_ref() - .map(|s| s.command.clone()) - .map(|c| md_mono(&c)) - .unwrap_or_default(), + lc.language_servers + .iter() + .filter_map(|ls| config.language_server.get(ls.name())) + .map(|s| md_mono(&s.command.clone())) + .collect::>() + .join(", "), ); md.push_str(&md_table_row(&row)); -- cgit v1.2.3-70-g09d2 From 7d20740b5b2e115e3075251204ee1ff1901166df Mon Sep 17 00:00:00 2001 From: Philipp Mildenberger Date: Sat, 18 Mar 2023 23:41:38 +0100 Subject: Fix docgen and lsp-stop documentation --- book/src/generated/typable-cmd.md | 2 +- helix-term/src/commands/typed.rs | 2 +- xtask/src/docgen.rs | 4 ++-- 3 files changed, 4 insertions(+), 4 deletions(-) (limited to 'xtask/src/docgen.rs') diff --git a/book/src/generated/typable-cmd.md b/book/src/generated/typable-cmd.md index cc2e87ea..0f488dc0 100644 --- a/book/src/generated/typable-cmd.md +++ b/book/src/generated/typable-cmd.md @@ -51,7 +51,7 @@ | `:update`, `:u` | Write changes only if the file has been modified. | | `:lsp-workspace-command` | Open workspace command picker | | `:lsp-restart` | Restarts the language servers used by the current doc | -| `:lsp-stop` | Stops the Language Server that is in use by the current doc | +| `:lsp-stop` | Stops the language servers that are used by the current doc | | `:tree-sitter-scopes` | Display tree sitter scopes, primarily for theming and development. | | `:debug-start`, `:dbg` | Start a debug session from a given template with given parameters. | | `:debug-remote`, `:dbg-tcp` | Connect to a debug adapter by TCP address and start a debugging session from a given template with given parameters. | diff --git a/helix-term/src/commands/typed.rs b/helix-term/src/commands/typed.rs index 38058ed5..5f94b7c4 100644 --- a/helix-term/src/commands/typed.rs +++ b/helix-term/src/commands/typed.rs @@ -2635,7 +2635,7 @@ pub const TYPABLE_COMMAND_LIST: &[TypableCommand] = &[ TypableCommand { name: "lsp-stop", aliases: &[], - doc: "Stops the Language Server that is in use by the current doc", + doc: "Stops the language servers that are used by the current doc", fun: lsp_stop, signature: CommandSignature::none(), }, diff --git a/xtask/src/docgen.rs b/xtask/src/docgen.rs index 3bd0592e..d360b4bd 100644 --- a/xtask/src/docgen.rs +++ b/xtask/src/docgen.rs @@ -97,8 +97,8 @@ pub fn lang_features() -> Result { } row.push( lc.language_servers - .iter() - .filter_map(|ls| config.language_server.get(ls.name())) + .keys() + .filter_map(|ls| config.language_server.get(ls)) .map(|s| md_mono(&s.command.clone())) .collect::>() .join(", "), -- cgit v1.2.3-70-g09d2 From 9d089c27c77cb2797a0495b46477dfe348d09a91 Mon Sep 17 00:00:00 2001 From: Philipp Mildenberger Date: Mon, 20 Mar 2023 01:44:44 +0100 Subject: Fix docgen again --- xtask/src/docgen.rs | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) (limited to 'xtask/src/docgen.rs') diff --git a/xtask/src/docgen.rs b/xtask/src/docgen.rs index d360b4bd..034d9918 100644 --- a/xtask/src/docgen.rs +++ b/xtask/src/docgen.rs @@ -97,8 +97,8 @@ pub fn lang_features() -> Result { } row.push( lc.language_servers - .keys() - .filter_map(|ls| config.language_server.get(ls)) + .iter() + .filter_map(|ls| config.language_server.get(&ls.name)) .map(|s| md_mono(&s.command.clone())) .collect::>() .join(", "), -- cgit v1.2.3-70-g09d2