aboutsummaryrefslogtreecommitdiff
diff options
context:
space:
mode:
authorBlaž Hrastnik2021-09-08 07:53:10 +0000
committerBlaž Hrastnik2021-09-24 01:30:17 +0000
commit9ea9e779b2eef293c14ae50d5767035c0a9544a5 (patch)
tree185910e2d59de7c2502d13fc6e1db09e25a59728
parenta958d34bfbcf45c01ce0d9c0d76e681fb863fc6a (diff)
experiment: Move keep_primary_selection to ,
-rw-r--r--book/src/keymap.md3
-rw-r--r--helix-term/src/commands.rs4
-rw-r--r--helix-term/src/keymap.rs5
3 files changed, 6 insertions, 6 deletions
diff --git a/book/src/keymap.md b/book/src/keymap.md
index 5928a1ae..aed48d5b 100644
--- a/book/src/keymap.md
+++ b/book/src/keymap.md
@@ -86,6 +86,7 @@
| `Alt-s` | Split selection on newlines | `split_selection_on_newline` |
| `;` | Collapse selection onto a single cursor | `collapse_selection` |
| `Alt-;` | Flip selection cursor and anchor | `flip_selections` |
+| `,` | Keep only the primary selection | `keep_primary_selection` |
| `C` | Copy selection onto the next line | `copy_selection_on_next_line` |
| `Alt-C` | Copy selection onto the previous line | `copy_selection_on_prev_line` |
| `(` | Rotate main selection forward | `rotate_selections_backward` |
@@ -99,7 +100,6 @@
| `J` | Join lines inside selection | `join_selections` |
| `K` | Keep selections matching the regex TODO: overlapped by hover help | `keep_selections` |
| `$` | Pipe each selection into shell command, keep selections where command returned 0 | `shell_keep_pipe` |
-| `Space` | Keep only the primary selection TODO: overlapped by space mode | `keep_primary_selection` |
| `Ctrl-c` | Comment/uncomment the selections | `toggle_comments` |
### Search
@@ -200,7 +200,6 @@ This layer is a kludge of mappings, mostly pickers.
| `a` | Apply code action | `code_action` |
| `'` | Open last fuzzy picker | `last_picker` |
| `w` | Enter [window mode](#window-mode) | N/A |
-| `space` | Keep primary selection TODO: it's here because space mode replaced it | `keep_primary_selection` |
| `p` | Paste system clipboard after selections | `paste_clipboard_after` |
| `P` | Paste system clipboard before selections | `paste_clipboard_before` |
| `y` | Join and yank selections to clipboard | `yank_joined_to_clipboard` |
diff --git a/helix-term/src/commands.rs b/helix-term/src/commands.rs
index 117ba046..e3c351f6 100644
--- a/helix-term/src/commands.rs
+++ b/helix-term/src/commands.rs
@@ -2825,6 +2825,10 @@ fn open_above(cx: &mut Context) {
fn normal_mode(cx: &mut Context) {
let (view, doc) = current!(cx.editor);
+ if doc.mode == Mode::Normal {
+ return;
+ }
+
doc.mode = Mode::Normal;
doc.append_changes_to_history(view.id);
diff --git a/helix-term/src/keymap.rs b/helix-term/src/keymap.rs
index f9bfcc50..a83b960e 100644
--- a/helix-term/src/keymap.rs
+++ b/helix-term/src/keymap.rs
@@ -436,7 +436,6 @@ impl Default for Keymaps {
"A" => append_to_line,
"o" => open_below,
"O" => open_above,
- // [<space> ]<space> equivalents too (add blank new line, no edit)
"d" => delete_selection,
// TODO: also delete without yanking
@@ -500,8 +499,7 @@ impl Default for Keymaps {
"K" => keep_selections,
// TODO: and another method for inverse
- // TODO: clashes with space mode
- "space" => keep_primary_selection,
+ "," => keep_primary_selection,
// "q" => record_macro,
// "Q" => replay_macro,
@@ -554,7 +552,6 @@ impl Default for Keymaps {
"p" => paste_clipboard_after,
"P" => paste_clipboard_before,
"R" => replace_selections_with_clipboard,
- "space" => keep_primary_selection,
"/" => global_search,
},
"z" => { "View"