diff options
author | Michael Davis | 2022-10-20 19:14:27 +0000 |
---|---|---|
committer | Blaž Hrastnik | 2022-10-20 23:43:15 +0000 |
commit | 313579d27ce6ad55b5c2410856e6aa62a7778320 (patch) | |
tree | a820574a08ff7ee556f028ff42ba2c0533d7b161 /docs/CONTRIBUTING.md | |
parent | 1243db11a55a9f431a4b6bbf56c1953b2262d8b7 (diff) |
Remove language-server configuration in integration tests
This change removes language server configuration from the default
languages.toml config for integration tests. No integration-tests
currently depend on the availability of a language server but if any
future test needs to, it may provide a language server configuration
by passing an override into the `test_syntax_conf` helper.
Language-servers in integration tests cause false-positive failures
when running integration tests in GitHub Actions CI. The Windows
runner appears to have `clangd` installed and all OS runners have
the `R` binary installed but not the `R` language server package.
If a test file created by `tempfile::NamedTempFile` happens to have a
file extension of `r`, the test will most likely fail because the
R language server will fail to start and will become a broken pipe,
meaning that it will fail to shutdown within the timeout, causing a
false-positive failure. This happens surprisingly often in practice.
Language servers (especially rust-analyzer) also emit unnecessary
log output when initializing, which this change silences.
Diffstat (limited to 'docs/CONTRIBUTING.md')
0 files changed, 0 insertions, 0 deletions