diff options
author | Gokul Soumya | 2021-11-29 01:33:53 +0000 |
---|---|---|
committer | GitHub | 2021-11-29 01:33:53 +0000 |
commit | dc53e65b9e9be71c49eaa86e0f4dabb69f586e2e (patch) | |
tree | 33dac12d972639c40ff5a3518141e919e68045d8 /helix-core/src/selection.rs | |
parent | 1d773bcefb40f69fe31dc048bfbdd83601fe0e62 (diff) |
Fix surround cursor position calculation (#1183)
Fixes #1077. This was caused by the assumption that a block
cursor is represented as zero width internally and simply
rendered to be a single width selection, where as in reality
a block cursor is an actual single width selection in form and
function.
Behavioural changes:
1. Surround selection no longer works when cursor is _on_ a
surround character that has matching pairs (like `'`
or `"`). This was the intended behaviour from the start
but worked till now because of the cursor position
calculation mismatch.
Diffstat (limited to 'helix-core/src/selection.rs')
-rw-r--r-- | helix-core/src/selection.rs | 6 |
1 files changed, 3 insertions, 3 deletions
diff --git a/helix-core/src/selection.rs b/helix-core/src/selection.rs index b4d1dffa..116a1c7c 100644 --- a/helix-core/src/selection.rs +++ b/helix-core/src/selection.rs @@ -308,10 +308,10 @@ impl Range { } impl From<(usize, usize)> for Range { - fn from(tuple: (usize, usize)) -> Self { + fn from((anchor, head): (usize, usize)) -> Self { Self { - anchor: tuple.0, - head: tuple.1, + anchor, + head, horiz: None, } } |