diff options
author | Michael Davis | 2022-11-19 04:14:36 +0000 |
---|---|---|
committer | GitHub | 2022-11-19 04:14:36 +0000 |
commit | 8be2d1dcbfeff88f47b8bfb9685f2ab45a72efb5 (patch) | |
tree | 4526d557af97febb6b52f2b9676581eb2fae549a /helix-term/src/application.rs | |
parent | 598bd8bf11b0f6ee6cf8b59c3415fa0d5d6cd1ff (diff) |
Handle language server termination (#4797)
This change handles a language server exiting. This was a UX sore-spot:
if a language server crashed, Helix did not recognize the exit and
continued to send requests to it. All requests would timeout since they
would not receive responses. This would also hold-up Helix closing
itself down since it would try to gracefully shutdown the server which
is implemented in the LSP spec as a request.
We could attempt to automatically restart the language server on crash.
I left this for future work since that change will need to be slightly
complicated: it will need to cover the case of a language server
repeatedly crashing.
Diffstat (limited to 'helix-term/src/application.rs')
-rw-r--r-- | helix-term/src/application.rs | 26 |
1 files changed, 26 insertions, 0 deletions
diff --git a/helix-term/src/application.rs b/helix-term/src/application.rs index 39a6532d..99d3af18 100644 --- a/helix-term/src/application.rs +++ b/helix-term/src/application.rs @@ -871,6 +871,32 @@ impl Application { Notification::ProgressMessage(_params) => { // do nothing } + Notification::Exit => { + self.editor.set_status("Language server exited"); + + // Clear any diagnostics for documents with this server open. + let urls: Vec<_> = self + .editor + .documents_mut() + .filter_map(|doc| { + if doc.language_server().map(|server| server.id()) + == Some(server_id) + { + doc.set_diagnostics(Vec::new()); + doc.url() + } else { + None + } + }) + .collect(); + + for url in urls { + self.editor.diagnostics.remove(&url); + } + + // Remove the language server from the registry. + self.editor.language_servers.remove_by_id(server_id); + } } } Call::MethodCall(helix_lsp::jsonrpc::MethodCall { |