diff options
| author | Gokul Soumya | 2022-07-19 02:28:24 +0000 |
|---|---|---|
| committer | GitHub | 2022-07-19 02:28:24 +0000 |
| commit | 791bf7e50a19bcf7612788deb7514847089cb976 (patch) | |
| tree | 0bac607be8b940aed8000b77a2f4dfa2e14882b8 /helix-term/src/commands/typed.rs | |
| parent | 02f009921007301284cbb0db4bc36bc629088fbb (diff) | |
Add lsp signature help (#1755)
* Add lsp signature help
* Do not move signature help popup on multiple triggers
* Highlight current parameter in signature help
* Auto close signature help
* Position signature help above to not block completion
* Update signature help on backspace/insert mode delete
* Add lsp.auto-signature-help config option
* Add serde default annotation for LspConfig
* Show LSP inactive message only if signature help is invoked manually
* Do not assume valid signature help response from LSP
Malformed LSP responses are common, and these should not crash the
editor.
* Check signature help capability before sending request
* Reuse Open enum for PositionBias in popup
* Close signature popup and exit insert mode on escape
* Add config to control signature help docs display
* Use new Margin api in signature help
* Invoke signature help on changing to insert mode
Diffstat (limited to 'helix-term/src/commands/typed.rs')
| -rw-r--r-- | helix-term/src/commands/typed.rs | 8 |
1 files changed, 3 insertions, 5 deletions
diff --git a/helix-term/src/commands/typed.rs b/helix-term/src/commands/typed.rs index 4e1ac0da..fb03af44 100644 --- a/helix-term/src/commands/typed.rs +++ b/helix-term/src/commands/typed.rs @@ -1501,11 +1501,9 @@ fn run_shell_command( format!("```sh\n{}\n```", output), editor.syn_loader.clone(), ); - let mut popup = Popup::new("shell", contents); - popup.set_position(Some(helix_core::Position::new( - editor.cursor().0.unwrap_or_default().row, - 2, - ))); + let popup = Popup::new("shell", contents).position(Some( + helix_core::Position::new(editor.cursor().0.unwrap_or_default().row, 2), + )); compositor.replace_or_push("shell", popup); }); Ok(call) |