diff options
author | Michael Davis | 2022-10-22 01:04:50 +0000 |
---|---|---|
committer | GitHub | 2022-10-22 01:04:50 +0000 |
commit | d7d0d5ffb79b6f2e09c6ab8af6e112c41e6f73e8 (patch) | |
tree | 5078c81ef786f29d9739ec4cd65d87eae83b2e71 /helix-term/src/ui/editor.rs | |
parent | 17daf6ac0a1a7ef4a44078ef11cc150a8fa41ff0 (diff) |
lsp: Resolve completion items missing documentation on idle (#4406)
Some language servers may not send the `documentation` field if it
is expensive to compute. Clients can request the missing field with
a completionItem/resolve request.
In this change we use the idle-timeout event to ensure that the current
completion item is resolved.
Diffstat (limited to 'helix-term/src/ui/editor.rs')
-rw-r--r-- | helix-term/src/ui/editor.rs | 13 |
1 files changed, 9 insertions, 4 deletions
diff --git a/helix-term/src/ui/editor.rs b/helix-term/src/ui/editor.rs index 43b1e7a0..b1bb02c7 100644 --- a/helix-term/src/ui/editor.rs +++ b/helix-term/src/ui/editor.rs @@ -1097,10 +1097,15 @@ impl EditorView { } pub fn handle_idle_timeout(&mut self, cx: &mut commands::Context) -> EventResult { - if self.completion.is_some() - || cx.editor.mode != Mode::Insert - || !cx.editor.config().auto_completion - { + if let Some(completion) = &mut self.completion { + return if completion.ensure_item_resolved(cx) { + EventResult::Consumed(None) + } else { + EventResult::Ignored(None) + }; + } + + if cx.editor.mode != Mode::Insert || !cx.editor.config().auto_completion { return EventResult::Ignored(None); } |