diff options
author | Rohan Jain | 2022-03-14 02:46:23 +0000 |
---|---|---|
committer | GitHub | 2022-03-14 02:46:23 +0000 |
commit | 1ac576f2b3ab3b3b1c398c57e1269682e6f63f3e (patch) | |
tree | 8b9177d86660039e15e1f0dd2cb7549fc2ba7f81 /helix-term/src/ui | |
parent | 29d6a5a9b6fde7b9e82b6abceef892fba42d8da4 (diff) |
Handle panic on move within empty picker (#1786)
When the picker results output is empty, movement actions result in a panic:
```
thread 'main' panicked at 'attempt to calculate the remainder with a divisor of zero', helix-term/src/ui/picker.rs:420:31
note: run with `RUST_BACKTRACE=1` environment variable to display a backtrace
```
This could be a no-op instead when the matches length is zero.
Diffstat (limited to 'helix-term/src/ui')
-rw-r--r-- | helix-term/src/ui/picker.rs | 5 |
1 files changed, 5 insertions, 0 deletions
diff --git a/helix-term/src/ui/picker.rs b/helix-term/src/ui/picker.rs index 5d88622c..3f2da92f 100644 --- a/helix-term/src/ui/picker.rs +++ b/helix-term/src/ui/picker.rs @@ -415,6 +415,11 @@ impl<T> Picker<T> { pub fn move_by(&mut self, amount: usize, direction: Direction) { let len = self.matches.len(); + if len == 0 { + // No results, can't move. + return; + } + match direction { Direction::Forward => { self.cursor = self.cursor.saturating_add(amount) % len; |