aboutsummaryrefslogtreecommitdiff
path: root/helix-term/tests/test
diff options
context:
space:
mode:
authorMike Trinkala2024-03-07 17:20:07 +0000
committerGitHub2024-03-07 17:20:07 +0000
commitcb01e52cd8b8021686ee98dd4d53dff8cdc826a9 (patch)
tree270c2ab4d42aa025fe16819b32dbde039c12cc08 /helix-term/tests/test
parentb93fae9c8b955e11f427979134e3494294e8e2e0 (diff)
Fix panic in surround_replace/delete nested multi-cursor (#9815)
Test Document ------------- ``` {{ } } ``` Steps To Reproduce ------------------ 1. 2j # move_visual_line_down 1. C # copy_selection_on_next_line 1. mdm # surround_delete Debug ----- `assertion failed: last <= from', transaction.rs:597:13` Release ------- `called `Result::unwrap()` on an `Err` value: Char range out of bounds: char range 18446744073709551614..18446744073709551615, Rope/RopeSlice char length 7', ropey-1.6.1/src/rope.rs:546:37` Description ----------- Processing the surrounding pairs in order violates the assertion the ranges are ordered. To handle nested surrounds all positions have to be sorted. Also surround_replace has to track the proper replacement character for each position.
Diffstat (limited to 'helix-term/tests/test')
-rw-r--r--helix-term/tests/test/movement.rs29
1 files changed, 29 insertions, 0 deletions
diff --git a/helix-term/tests/test/movement.rs b/helix-term/tests/test/movement.rs
index 0873edbe..4ebaae85 100644
--- a/helix-term/tests/test/movement.rs
+++ b/helix-term/tests/test/movement.rs
@@ -577,6 +577,23 @@ async fn test_surround_replace() -> anyhow::Result<()> {
))
.await?;
+ test((
+ platform_line(indoc! {"\
+ {{
+
+ #(}|)#
+ #[}|]#
+ "}),
+ "mrm)",
+ platform_line(indoc! {"\
+ ((
+
+ #()|)#
+ #[)|]#
+ "}),
+ ))
+ .await?;
+
Ok(())
}
@@ -604,5 +621,17 @@ async fn test_surround_delete() -> anyhow::Result<()> {
))
.await?;
+ test((
+ platform_line(indoc! {"\
+ {{
+
+ #(}|)#
+ #[}|]#
+ "}),
+ "mdm",
+ platform_line("\n\n#(\n|)##[\n|]#"),
+ ))
+ .await?;
+
Ok(())
}