diff options
| author | Filip Dutescu | 2023-02-20 04:00:00 +0000 |
|---|---|---|
| committer | GitHub | 2023-02-20 04:00:00 +0000 |
| commit | e3765ac6d20195d2434c8274850247fe0a044da0 (patch) | |
| tree | f221c9d2413bfc9a1618bb22ea51d5437d0e2eb7 /logo_dark.svg | |
| parent | 31b0c75832c56179e9fcb2301f1e92ac2fa116ff (diff) | |
feat(dap): send Disconnect if Terminated event received (#5532)
Send a `Disconnect` DAP request if the `Terminated` event is received.
According to the specification, if the debugging session was started by
as `launch`, the debuggee should be terminated alongside the session. If
instead the session was started as `attach`, it should not be disposed of.
This default behaviour can be overriden if the `supportTerminateDebuggee`
capability is supported by the adapter, through the `Disconnect` request
`terminateDebuggee` argument, as described in
[the specification][discon-spec].
This also implies saving the starting command for a debug sessions, in
order to decide which behaviour should be used, as well as validating the
capabilities of the adapter, in order to decide what the disconnect should
do.
An additional change made is handling of the `Exited` event, showing a
message if the exit code is different than `0`, for the user to be aware
off the termination failure.
[discon-spec]: https://microsoft.github.io/debug-adapter-protocol/specification#Requests_Disconnect
Closes: #4674
Signed-off-by: Filip Dutescu <filip.dutescu@gmail.com>
Diffstat (limited to 'logo_dark.svg')
0 files changed, 0 insertions, 0 deletions