diff options
| author | Michael Davis | 2023-07-25 18:15:36 +0000 |
|---|---|---|
| committer | Blaž Hrastnik | 2023-07-27 02:50:19 +0000 |
| commit | 98ef05d768d287fef2eb790e0a8a6e9a72832e00 (patch) | |
| tree | 856fa79ea0924834f786a22a76ddfbe188301330 /logo_light.svg | |
| parent | f0b877e2588306882f71eaad45a3f3e604885a34 (diff) | |
Prefer RopeSlice to &Rope in helix_core::syntax
Pascal and I discussed this and we think it's generally better to
take a 'RopeSlice' rather than a '&Rope'. The code block rendering
function in the markdown component module is a good example for how
this can be useful: we can remove an allocation of a rope and instead
directly turn a '&str' into a 'RopeSlice' which is very cheap.
A change to prefer 'RopeSlice' to '&Rope' whenever the rope isn't
modified would be nice, but it would be a very large diff (around 500+
500-). Starting off with just the syntax functions seems like a nice
middle-ground, and we can remove a Rope allocation because of it.
Co-authored-by: Pascal Kuthe <pascal.kuthe@semimod.de>
Diffstat (limited to 'logo_light.svg')
0 files changed, 0 insertions, 0 deletions