aboutsummaryrefslogtreecommitdiff
path: root/helix-term/src/job.rs
diff options
context:
space:
mode:
Diffstat (limited to 'helix-term/src/job.rs')
-rw-r--r--helix-term/src/job.rs36
1 files changed, 30 insertions, 6 deletions
diff --git a/helix-term/src/job.rs b/helix-term/src/job.rs
index e5147992..2888b6eb 100644
--- a/helix-term/src/job.rs
+++ b/helix-term/src/job.rs
@@ -5,7 +5,11 @@ use crate::compositor::Compositor;
use futures_util::future::{BoxFuture, Future, FutureExt};
use futures_util::stream::{FuturesUnordered, StreamExt};
-pub type Callback = Box<dyn FnOnce(&mut Editor, &mut Compositor) + Send>;
+pub enum Callback {
+ EditorCompositor(Box<dyn FnOnce(&mut Editor, &mut Compositor) + Send>),
+ Editor(Box<dyn FnOnce(&mut Editor) + Send>),
+}
+
pub type JobFuture = BoxFuture<'static, anyhow::Result<Option<Callback>>>;
pub struct Job {
@@ -68,9 +72,10 @@ impl Jobs {
) {
match call {
Ok(None) => {}
- Ok(Some(call)) => {
- call(editor, compositor);
- }
+ Ok(Some(call)) => match call {
+ Callback::EditorCompositor(call) => call(editor, compositor),
+ Callback::Editor(call) => call(editor),
+ },
Err(e) => {
editor.set_error(format!("Async job failed: {}", e));
}
@@ -93,13 +98,32 @@ impl Jobs {
}
/// Blocks until all the jobs that need to be waited on are done.
- pub async fn finish(&mut self) -> anyhow::Result<()> {
+ pub async fn finish(
+ &mut self,
+ editor: &mut Editor,
+ mut compositor: Option<&mut Compositor>,
+ ) -> anyhow::Result<()> {
log::debug!("waiting on jobs...");
let mut wait_futures = std::mem::take(&mut self.wait_futures);
+
while let (Some(job), tail) = wait_futures.into_future().await {
match job {
- Ok(_) => {
+ Ok(callback) => {
wait_futures = tail;
+
+ if let Some(callback) = callback {
+ // clippy doesn't realize this is an error without the derefs
+ #[allow(clippy::needless_option_as_deref)]
+ match callback {
+ Callback::EditorCompositor(call) if compositor.is_some() => {
+ call(editor, compositor.as_deref_mut().unwrap())
+ }
+ Callback::Editor(call) => call(editor),
+
+ // skip callbacks for which we don't have the necessary references
+ _ => (),
+ }
+ }
}
Err(e) => {
self.wait_futures = tail;