aboutsummaryrefslogtreecommitdiff
Commit message (Collapse)AuthorAge
* LSP: Forcefully shutdown uninitialized servers (#7449)Michael Davis2023-06-29
| | | | | | | | | | | | | | | | | | The LSP spec has this to say about initialize: > Until the server has responded to the `initialize` request with an > `InitializeResult`, the client must not send any additional requests > or notifications to the server. (https://microsoft.github.io/language-server-protocol/specifications/lsp/3.17/specification/#initialize) The spec is not really explicit about how to handle this scenario. Before a client sends the 'initialize' request we are allowed to send an 'exit' notification, but after 'initialize' we can't send any requests (like shutdown) or notifications (like exit). So my intepretation is that we should forcefully close the server in this state. This matches the behavior of Neovim's built-in LSP client: https://github.com/neovim/neovim/blob/5ceb2238d3685255cd517ca87fd7edae9ed88811/runtime/lua/vim/lsp.lua#L1610-L1628
* update OneDarker theme to use light-gray for inlay hints. (#7433)gobraves2023-06-29
|
* LSP: Use negotiated position encoding for workspace edits (#7469)Michael Davis2023-06-29
| | | | Previously this was hard-coded to UTF-8 but we might have negotiated another position encoding.
* LSP: Discard publishDiagnostic from uninitialized servers (#7467)Michael Davis2023-06-28
| | | | | | | | | | | | | | The spec explicitly disallows publishDiagnostic to be sent before the initialize response: > ... the server is not allowed to send any requests or notifications to > the client until it has responded with an InitializeResult ... (https://microsoft.github.io/language-server-protocol/specifications/lsp/3.17/specification/#initialize) But if a non-compliant server sends this we currently panic because we '.expect()' the server capabilities to be known to fetch the position encoding. Instead of panicking we can discard the notification and log the non-compliant behavior.
* correctly map unsorted positions (#7471)Pascal Kuthe2023-06-28
| | | | | | | | | | | * correctly map unsorted positions * Fix typo Co-authored-by: Michael Davis <mcarsondavis@gmail.com> --------- Co-authored-by: Michael Davis <mcarsondavis@gmail.com>
* build(deps): bump libc from 0.2.146 to 0.2.147 (#7463)dependabot[bot]2023-06-27
| | | | | | | | | | | | | | | Bumps [libc](https://github.com/rust-lang/libc) from 0.2.146 to 0.2.147. - [Release notes](https://github.com/rust-lang/libc/releases) - [Commits](https://github.com/rust-lang/libc/compare/0.2.146...0.2.147) --- updated-dependencies: - dependency-name: libc dependency-type: direct:production update-type: version-update:semver-patch ... Signed-off-by: dependabot[bot] <support@github.com> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
* build(deps): bump serde_json from 1.0.97 to 1.0.99 (#7462)dependabot[bot]2023-06-27
| | | | | | | | | | | | | | | Bumps [serde_json](https://github.com/serde-rs/json) from 1.0.97 to 1.0.99. - [Release notes](https://github.com/serde-rs/json/releases) - [Commits](https://github.com/serde-rs/json/compare/v1.0.97...v1.0.99) --- updated-dependencies: - dependency-name: serde_json dependency-type: direct:production update-type: version-update:semver-patch ... Signed-off-by: dependabot[bot] <support@github.com> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
* build(deps): bump toml from 0.7.4 to 0.7.5 (#7461)dependabot[bot]2023-06-27
| | | | | | | | | | | | | | Bumps [toml](https://github.com/toml-rs/toml) from 0.7.4 to 0.7.5. - [Commits](https://github.com/toml-rs/toml/compare/toml-v0.7.4...toml-v0.7.5) --- updated-dependencies: - dependency-name: toml dependency-type: direct:production update-type: version-update:semver-patch ... Signed-off-by: dependabot[bot] <support@github.com> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
* build(deps): bump gix from 0.46.0 to 0.47.0 (#7460)dependabot[bot]2023-06-27
| | | | | | | | | | | | | | | | Bumps [gix](https://github.com/Byron/gitoxide) from 0.46.0 to 0.47.0. - [Release notes](https://github.com/Byron/gitoxide/releases) - [Changelog](https://github.com/Byron/gitoxide/blob/main/CHANGELOG.md) - [Commits](https://github.com/Byron/gitoxide/compare/gix-v0.46.0...gix-v0.47.0) --- updated-dependencies: - dependency-name: gix dependency-type: direct:production update-type: version-update:semver-minor ... Signed-off-by: dependabot[bot] <support@github.com> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
* Mark buffers created from stdin as modified (#7431)Michael Davis2023-06-26
| | | | | | | | | This resolves some confusing behavior where a scratch document created by piping into hx is discarded when navigating away from that document. We discard any scratch documents that are not modified and the original `Editor::new_file_from_stdin` would create unmodified documents. We refactor this function to create an empty document first and then to apply the text from stdin as a change.
* fix: Regression from d491e234f4eb4d8c3869f44ab71fedf022dc463eBlaž Hrastnik2023-06-26
|
* move normalize fastpath into normalize functionPascal Kuthe2023-06-25
|
* map positions through changes in O(N)Pascal Kuthe2023-06-25
|
* feat(toml): highlight table headers (#7441)Branch Vincent2023-06-24
|
* highlight(matlab): Bumps tree-sitter-matlab commit. (#7442)Álan Crístoffer2023-06-24
|
* Allow any indent size from 1 to 16 (#7429)Scott Driggers2023-06-23
|
* Replace MATLAB grammar (#7388)Álan Crístoffer2023-06-22
|
* Theme: port of Zed's OneDark and OneLight themes (#7250)eh2023-06-22
|
* make TS matching fallback to plaintextPascal Kuthe2023-06-22
|
* Avoid false positives in non-fuzzy bracket matchPascal Kuthe2023-06-22
|
* match pairs which don't form a standalone TS nodePascal Kuthe2023-06-22
|
* Fix tree sitter chunking (#7417)A-Walrus2023-06-21
| | | | | Call as bytes before slicing, that way you can take bytes that aren't aligned to chars. Should technically also be slightly faster since you don't have to check alignment...
* build(deps): bump bitflags from 2.3.1 to 2.3.2 (#7394)dependabot[bot]2023-06-20
| | | | Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
* build(deps): bump serde_json from 1.0.96 to 1.0.97 (#7393)dependabot[bot]2023-06-20
| | | | | | | | | | | | | | | Bumps [serde_json](https://github.com/serde-rs/json) from 1.0.96 to 1.0.97. - [Release notes](https://github.com/serde-rs/json/releases) - [Commits](https://github.com/serde-rs/json/compare/v1.0.96...v1.0.97) --- updated-dependencies: - dependency-name: serde_json dependency-type: direct:production update-type: version-update:semver-patch ... Signed-off-by: dependabot[bot] <support@github.com> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
* build(deps): bump cachix/install-nix-action from 21 to 22 (#7392)dependabot[bot]2023-06-20
| | | | Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
* remove mention of Wasm from `vision.md` (#7395)Kirawi2023-06-20
|
* highlight(sql): Update tree-sitter-sql to `98a7fc9` (#7387)LeoniePhiline2023-06-19
| | | | | * highlight(sql): Update tree-sitter-sql to 92018a3 * highlight(sql): Update tree-sitter-sql to 98a7fc9
* Fix Component implementations for Picker (#7382)Michael Davis2023-06-19
|
* Merge pull request #7264 from the-mikedavis/merge-picker-and-filepickerPascal Kuthe2023-06-19
|\ | | | | Merge FilePicker into Picker
| * Completely remove old Picker and rename FilePicker to PickerGokul Soumya2023-06-18
| |
| * Make file preview callback optionalMichael Davis2023-06-18
| | | | | | | | | | | | | | When Picker and FilePicker are merged, not all Pickers will be able to show a preview. Co-authored-by: Gokul Soumya <gokulps15@gmail.com>
| * Move FilePicker struct def closer to impl blockGokul Soumya2023-06-18
| |
| * Render the preview in FilePickerGokul Soumya2023-06-18
| |
| * Move Picker::render into FilePicker::renderGokul Soumya2023-06-18
| |
| * Move Component methods except render() to FilePickerGokul Soumya2023-06-18
| |
| * Move handle_event methods from Picker to FilePickerGokul Soumya2023-06-18
| |
| * Move navigation methods from Picker to FilePickerGokul Soumya2023-06-18
| |
| * Move scoring functions from Picker to FilePickerGokul Soumya2023-06-18
| |
| * Copy struct fields and new() from Picker to FilePickerGokul Soumya2023-06-18
| |
| * Move FilePicker::render from Component impl to normal implGokul Soumya2023-06-18
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | Merges the code for the Picker and FilePicker into a single Picker that can show a file preview if a preview callback is provided. This change was mainly made to facilitate refactoring out a simple skeleton of a picker that does not do any filtering to be reused in a normal Picker and a DynamicPicker (see #5714; in particular [mikes-comment] and [gokuls-comment]). The crux of the issue is that a picker maintains a list of predefined options (eg. list of files in the directory) and (re-)filters them every time the picker prompt changes, while a dynamic picker (eg. interactive global search, #4687) recalculates the full list of options on every prompt change. Using a filtering picker to drive a dynamic picker hence does duplicate work of filtering thousands of matches for no reason. It could also cause problems like interfering with the regex pattern in the global search. I tried to directly extract a PickerBase to be reused in Picker and FilePicker and DynamicPicker, but the problem is that DynamicPicker is actually a DynamicFilePicker (i.e. it can preview file contents) which means we would need PickerBase, Picker, FilePicker, DynamicPicker and DynamicFilePicker and then another way of sharing the previewing code between a FilePicker and a DynamicFilePicker. By merging Picker and FilePicker into Picker, we only need PickerBase, Picker and DynamicPicker. [gokuls-comment]: https://github.com/helix-editor/helix/issues/5714#issuecomment-1410949578 [mikes-comment]: https://github.com/helix-editor/helix/issues/5714#issuecomment-1407451963
* | Allow ANSI colors in themes (#5119)tomleb2023-06-19
|/
* Use default line ending in open command (#7357)Alex2023-06-17
|
* Add forth-lsp and update tree-sitter-forth (#7334)Alexander Brevig2023-06-16
| | | | | * feat: add forth lsp and update tree sitter * fix: update highlights
* Add yank_joined command (#7195)spectre2562023-06-16
| | | | | Resolves issue #6888 by adding a command to join all selections and yank them to the specified register. The typed command takes an argument as the separator to use when joining the selections.
* Add config for default line ending (#5621)Alex2023-06-16
|
* Webc language support (#7290)Ivan Svoboda2023-06-13
| | | | | * feat: add webc language support * feat: add to lang-support book webc
* Explain how to enter Select mode in keymap (#7333)Thomas Aarholt2023-06-13
| | | | | | | * Explain how to enter Select mode Also added an equivalent explanation that Insert mode is the default, with how to return to it. * Fix glarious typo
* Preview scratch buffers in jumplist picker (#7331)A-Walrus2023-06-13
|
* Fix next/prev tree-sitter inconsistency (#7332)A-Walrus2023-06-13
| | | | | | | | | * Fix next/prev tree-sitter inconsistency Before there where different results going to next or previous due to sorting not dealing with multiple captures that start/end at the same pos. I chose to prefer longer matches. * Revert unnecessary change
* Add merionette theme (#7186)Jorge Santiago2023-06-13
|