summaryrefslogtreecommitdiff
Commit message (Collapse)AuthorAge
* respect line annotations in char_idx_at_visual_row_offsetPascal Kuthe2023-03-27
| | | | | | | | | | | | | | char_idx_at_visual_row_offset asssumed that a single line/block break always corresponded to a vertical offset of 1. However conceal can hide the line break (in which case the certical offset would be 0) and line annotations (or softwrapped inlay hints at the end of the line) can insert addtional vertical lines. To correctly account for these cases we simply compute the visual offset of the start of the next block from the previous block instead of the visual offset of the block end. This means that the line breaks at the end of the block (however many there may be) are automatically included and we don't need to manually add 1 to the `row_offset` anymore.
* do not ignore mouse scrolling when on top of virtual textPascal Kuthe2023-03-27
|
* make scrolloff calculation consistentPascal Kuthe2023-03-27
| | | | | | While scrolling (with the `scroll`) command scrolloff was calculated slightly differently than in `ensure_cursor_in_view` which could cause the cursor to get stuck while scrolling
* allow scrolling past virtual text linePascal Kuthe2023-03-27
| | | | | | | | | | | | | Virtual text lines (either caused by softwrapped inlay hints that take multiple or line annotations) currently block scrolling downwards. if the visual offset passed to char_idx_at_visual_offset or visual_offset_from_block is within a virtual text line then the char position before the virtual text and a visual offset are returned. We previously ignored that visual offset and as a result the cursor would be stuck at the start of the virtual text. This commit fixes that by simply moving the cursor to the next char (so past the virtual text) if this visual offset is non-zero
* use partition_point instead of binary_search_byPascal Kuthe2023-03-27
| | | | | | | | Using `partition_point` ensures we always find the first entry. With binary search it is "random" (deterministic but implementation specific) which index is retruned if there are multiple equal elements. `partition_point` was added to the standard library to cover extactly the usecase here.
* fix view anchors not at start of a visual linePascal Kuthe2023-03-27
| | | | | | | | | | | | | | | | | | | | | The top of a view is marked by a char idx anchor. That char idx is usually the first character of the visual line it's on. We use a char index instead of a line index because the view may start in the middle of a line with soft wrapping. However, it's possible to temporarily endup in a state where this anchor is not the first character of the first visual line. This is pretty rare because edits usually happen inside/after the view. In most cases we handle this case correctly. However, if the cursor is before the anchor (but still in view) there can be crashes or visual artifacts. This is caused by the fact that visual_offset_from_anchor (and the positioning code in view.rs) incorrectly assumed that the (cursor) position is always after the view anchor if the cursor is in view. But if the anchor is not the first character of the first visual line this is not the case anymore. In that case crashes and visual artifacts are possible. This commit fixes that problem by changing `visual_offset_from_anchor` (and callsites) to properly consider that case.
* remove incorrect assertPascal Kuthe2023-03-27
| | | | | This assert was added during early development of #5420 and makes no sense with the current code. We simply forgot to remove it.
* Initial Nim language support (#6123)JJ2023-03-26
|
* Add language support for rego (OpenPolicyAgent) (#6415)Juan C. Müller2023-03-26
|
* log failures in the git integration (#6441)Pascal Kuthe2023-03-26
|
* Add vhdl language support (#5826)Tom Burdick2023-03-25
| | | | | | | Simple highlight query file with keywords and builtin types matching. Many VHDL types however are defined in std libraries which do not currently get matched on. This is because the grammar doesn't consider them builtin types.
* Add theme keys for (un)checked markup list items (#6434)Erasin Wang2023-03-25
|
* feat(languages): highlight .svg as xml (#6431)Matouš Dzivjak2023-03-25
| | | | | Add "svg" as a file type for xml. Fixes: https://github.com/helix-editor/helix/issues/6337
* Recognize .cts and .mts file type as TypeScript (#6424)Alexis-Lapierre2023-03-24
| | | | | | | | | TypeScript can use three type of file extensions: - .ts for regular TypeScript - .cts for CommonJS modules - .mts for ES modules Official documentation on supported file extensions: https://www.typescriptlang.org/docs/handbook/esm-node.html#new-file-extensions
* Fix spelling of diagnostics (#6418)Juan C. Müller2023-03-24
|
* dracula theme: style wrap indicator like whitespace (#6414)Sebastian Zivota2023-03-23
|
* Add xib and storyboard file types (#6407)Aleksey Kuznetsov2023-03-22
|
* detailed snippet testsPascal Kuthe2023-03-22
|
* accept bracket snippet variables without defaultPascal Kuthe2023-03-22
|
* accept empty snippet regex replace elementsPascal Kuthe2023-03-22
|
* fix single-char variable namesPascal Kuthe2023-03-22
|
* do not fail snippet parsing when control chars are not explicitly escapedPascal Kuthe2023-03-22
|
* build(deps): bump bitflags from 1.3.2 to 2.0.2 (#6387)dependabot[bot]2023-03-22
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | * build(deps): bump bitflags from 1.3.2 to 2.0.2 Bumps [bitflags](https://github.com/bitflags/bitflags) from 1.3.2 to 2.0.2. - [Release notes](https://github.com/bitflags/bitflags/releases) - [Changelog](https://github.com/bitflags/bitflags/blob/main/CHANGELOG.md) - [Commits](https://github.com/bitflags/bitflags/compare/1.3.2...2.0.2) --- updated-dependencies: - dependency-name: bitflags dependency-type: direct:production update-type: version-update:semver-major ... Signed-off-by: dependabot[bot] <support@github.com> * deps: Resolve bitflags 2.0 breaking changes Bitflags 2.0 release made some breaking changes requiring some small changes to the Helix codebase. Almost all of the necessary changes are to manually `#[derive(..)]` trait implementations which are no longer automatically derived for all bitflags. All of these were previously automatically derived: #[derive(PartialEq, Eq, PartialOrd, Ord, Hash, Debug, Clone, Copy] I have derived the minimum traits for each bitflag type. The other change was to the `.bits` field. This is now a `.bits()` method so the usage of this has been updated in the `Borders` type. --------- Signed-off-by: dependabot[bot] <support@github.com> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com> Co-authored-by: Michael Davis <mcarsondavis@gmail.com>
* Show diagnostic codes for LSP diagnostics (#6378)Francesc Elies2023-03-21
| | | Co-authored-by: Michael Davis <mcarsondavis@gmail.com>
* Add `switch_statement` to ecma indents (#6369)Thor Adam2023-03-21
|
* Add initial Smithy support (#6370)zetashift2023-03-21
|
* fleet-dark improvements (#6375)Kristoffer Flottorp2023-03-21
| | | Co-authored-by: krfl <kr.fl@outlook.com>
* build(deps): bump serde from 1.0.152 to 1.0.158 (#6386)dependabot[bot]2023-03-21
| | | | | | | | | | | | | | | Bumps [serde](https://github.com/serde-rs/serde) from 1.0.152 to 1.0.158. - [Release notes](https://github.com/serde-rs/serde/releases) - [Commits](https://github.com/serde-rs/serde/compare/v1.0.152...v1.0.158) --- updated-dependencies: - dependency-name: serde dependency-type: direct:production update-type: version-update:semver-patch ... Signed-off-by: dependabot[bot] <support@github.com> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
* build(deps): bump futures-executor from 0.3.26 to 0.3.27 (#6388)dependabot[bot]2023-03-21
| | | | | | | | | | | | | | | | Bumps [futures-executor](https://github.com/rust-lang/futures-rs) from 0.3.26 to 0.3.27. - [Release notes](https://github.com/rust-lang/futures-rs/releases) - [Changelog](https://github.com/rust-lang/futures-rs/blob/master/CHANGELOG.md) - [Commits](https://github.com/rust-lang/futures-rs/compare/0.3.26...0.3.27) --- updated-dependencies: - dependency-name: futures-executor dependency-type: direct:production update-type: version-update:semver-patch ... Signed-off-by: dependabot[bot] <support@github.com> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
* build(deps): bump indoc from 1.0.9 to 2.0.1 (#6385)dependabot[bot]2023-03-21
| | | | | | | | | | | | | | | Bumps [indoc](https://github.com/dtolnay/indoc) from 1.0.9 to 2.0.1. - [Release notes](https://github.com/dtolnay/indoc/releases) - [Commits](https://github.com/dtolnay/indoc/compare/1.0.9...2.0.1) --- updated-dependencies: - dependency-name: indoc dependency-type: direct:production update-type: version-update:semver-major ... Signed-off-by: dependabot[bot] <support@github.com> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
* Run shell commands asynchronously (#6373)sarah2023-03-21
|
* theme(rose-pine): add inlay hints (#6384)not2023-03-20
| | | | | * add `ui.virtual.inlay-hint` * normalise line endings
* Add instructions for installing via AppImage (#6368)Gautam Panchal2023-03-20
|
* migrate test_with_config to use AppBuilderSkyler Hawthorne2023-03-20
|
* fix test::plainSkyler Hawthorne2023-03-20
| | | | test::plain uses char indices when it should use byte indices
* Allow explicit newlines in test DSLSkyler Hawthorne2023-03-20
| | | | | | | | | | | | | The current test DSL currently has no way to express being at the end of a line, save for putting an explicit LF or CRLF inside the `#[|]#`. The problem with this approach is that it can add unintended extra new lines if used in conjunction with raw strings, which insert newlines for you. This is a simple attempt to mitigate this problem. If there is an explicit newline character at the end of the selection, and then it is immediately followed by the same newline character at the right end of the selection, this following newline is removed. This way, one can express a cursor at the end of a line explicitly.
* refactor test editor configSkyler Hawthorne2023-03-20
|
* print doc state during testsSkyler Hawthorne2023-03-20
|
* make TestCase::From more genericSkyler Hawthorne2023-03-20
|
* factor write command tests to own moduleSkyler Hawthorne2023-03-20
|
* Disable auto-pairing ' by default in OCaml (#6381)pithlessly2023-03-20
| | | | Since OCaml uses 'a syntax for type variables, the editor shouldn't insert a second ', for the same reason as Rust.
* Update nord with inlay-hints (#6376)varon2023-03-20
|
* Document `ui.highlight` theme key (#6372)Aaron Bull Schaefer2023-03-20
| | | This scope was added via https://github.com/helix-editor/helix/commit/bf5b9a9f354135933d7970863cf81e5a36585d03
* Fix highlighting in picker with multiple columns (#6333)exp802023-03-18
|
* Add language support for Cap’n Proto format (#6325)angelodlfrtr2023-03-18
|
* Update tokyo-night with inlay-hints (#6349)Sora2023-03-18
|
* theme: update adwaita-dark for bufferline (#6342)Yutaro Ohno2023-03-17
| | | | The adwaita-dark theme has no distinction between active and inactive buffers on a bufferline. Add contrast to clarify differences.
* Update Serika themes for inlay-hints (#6344)VuiMuich2023-03-17
|
* Update queries for makefile (#6339)Erasin Wang2023-03-17
| | | | | - update variable and ref as paramter - add target as constant - add inject for shell_text
* Update ayu theme for inlay-hint (#6329)Ivan Tham2023-03-16
| | | Based on vscode ayu badge.