| Commit message (Collapse) | Author | Age | |
|---|---|---|---|
| * | jsonrpc: Skip serializing params if params are None (#5471) | Michael Davis | 2023-01-10 |
| | | | | | | | | | | | | | | | | | The JSONRPC spec says: > If present, parameters for the rpc call MUST be provided as a > Structured value https://www.jsonrpc.org/specification#parameter_structures (Where a "Structured value" is elsewhere defined as either a map or array.) This change skips the serialization of the `params` field for JSONRPC method calls and notifications if the `params` field is the `None` variant. This fixes compatibility with LSP servers which adhere closely to that part of the spec: `ocamllsp` in the wild. | ||
| * | Resolve a bunch of upcoming clippy lints | Blaž Hrastnik | 2022-11-04 |
| | | |||
| * | Fix tests again | Blaž Hrastnik | 2022-06-27 |
| | | |||
| * | Remove some more unwraps | Blaž Hrastnik | 2022-06-27 |
| | | |||
| * | embed jsonrpc types from jsonrpc-core crate (#2801) | Michael Davis | 2022-06-18 |
| We should not depend on jsonrpc-core anymore: * The project just announced it's no longer actively maintained[^1], preferring their new implementation in `jsonrpsee`. * The types are too strict: we would benefit from removing some `#[serde(deny_unknown_fields)]` annotations to allow language servers that disrespect the spec[^2]. * We don't use much of the project. Just the types out of core. These are easy to embed directly into the `helix-lsp` crate. [^1]: https://github.com/paritytech/jsonrpc/pull/674 [^2]: https://github.com/helix-editor/helix/issues/2786 | |||
 |
index : helix-ext | |
| [contrib] fork of the helix editor, with various inactive and rejected patches applied | git daemon user |
| summaryrefslogtreecommitdiff |