diff options
| author | j-james | 2022-12-03 05:52:50 +0000 |
|---|---|---|
| committer | j-james | 2022-12-03 05:52:50 +0000 |
| commit | a164c6c77d67c4622cb393c3a92b19acf371a58e (patch) | |
| tree | 5a43acd86559160b3e217e3deba5c7e71b39f8c2 | |
| parent | b50902287b3b733c3252c496829d023c05ab637a (diff) | |
Phase 4: Task 3
| -rw-r--r-- | README.md | 5 | ||||
| -rw-r--r-- | UML_Design_Diagram.png | bin | 0 -> 130843 bytes |
2 files changed, 4 insertions, 1 deletions
@@ -42,7 +42,10 @@ Removed tab /home/apropos/Projects/website/j-james/index.html from tablist ## Phase IV: Task 3 - +I think that the design structure shown by the UML diagram is overall pretty much fine, especially for a student project. +There are definitely some problems with it / things I'd do differently, however: +- The BrowserBar and BrowserCanvas have a mutual dependency with BrowserWindow: this doesn't make too much sense and was done because I needed to access BrowserWindow methods from within them. If I did it again, I would either nest the classes or use the Singleton design principle. +- The CssParser is not connected to anything else, as it went unused. I would like to use that class in the future - but I never fully finished implementing the HTML layout, so it didn't make sense to apply CSS. (The JsonUtils class is also unconnected, but that's just because it consists of only static methods.) ## credits diff --git a/UML_Design_Diagram.png b/UML_Design_Diagram.png Binary files differnew file mode 100644 index 0000000..0a46b96 --- /dev/null +++ b/UML_Design_Diagram.png |
