diff options
| author | Michael Davis | 2022-06-18 03:59:57 +0000 |
|---|---|---|
| committer | GitHub | 2022-06-18 03:59:57 +0000 |
| commit | 45ce1ebdb604ae8b044a012f2933e6a42574430a (patch) | |
| tree | e94d27727f7c7562f108ffba0dc4d5adb8e06d0e /helix-lsp/src/transport.rs | |
| parent | b13e534b92a2616134157d9df80c49dd6af223c6 (diff) | |
embed jsonrpc types from jsonrpc-core crate (#2801)
We should not depend on jsonrpc-core anymore:
* The project just announced it's no longer actively maintained[^1],
preferring their new implementation in `jsonrpsee`.
* The types are too strict: we would benefit from removing some
`#[serde(deny_unknown_fields)]` annotations to allow language
servers that disrespect the spec[^2].
* We don't use much of the project. Just the types out of core.
These are easy to embed directly into the `helix-lsp` crate.
[^1]: https://github.com/paritytech/jsonrpc/pull/674
[^2]: https://github.com/helix-editor/helix/issues/2786
Diffstat (limited to 'helix-lsp/src/transport.rs')
| -rw-r--r-- | helix-lsp/src/transport.rs | 3 |
1 files changed, 1 insertions, 2 deletions
diff --git a/helix-lsp/src/transport.rs b/helix-lsp/src/transport.rs index 6102c6c8..8aaeae3d 100644 --- a/helix-lsp/src/transport.rs +++ b/helix-lsp/src/transport.rs @@ -1,6 +1,5 @@ -use crate::{Error, Result}; +use crate::{jsonrpc, Error, Result}; use anyhow::Context; -use jsonrpc_core as jsonrpc; use log::{error, info}; use serde::{Deserialize, Serialize}; use serde_json::Value; |