diff options
author | Michael Davis | 2023-06-29 15:25:23 +0000 |
---|---|---|
committer | GitHub | 2023-06-29 15:25:23 +0000 |
commit | e0bb032f0e6dcc9b84e571c345928fba4054855e (patch) | |
tree | 06be3467b5ea95ad24aecb1d247b2550db928d72 /helix-term/src/commands | |
parent | b745fb255195b874b61b5bd92244c8a7b0bb7d46 (diff) |
LSP: Forcefully shutdown uninitialized servers (#7449)
The LSP spec has this to say about initialize:
> Until the server has responded to the `initialize` request with an
> `InitializeResult`, the client must not send any additional requests
> or notifications to the server.
(https://microsoft.github.io/language-server-protocol/specifications/lsp/3.17/specification/#initialize)
The spec is not really explicit about how to handle this scenario.
Before a client sends the 'initialize' request we are allowed to send an
'exit' notification, but after 'initialize' we can't send any requests
(like shutdown) or notifications (like exit). So my intepretation is
that we should forcefully close the server in this state.
This matches the behavior of Neovim's built-in LSP client:
https://github.com/neovim/neovim/blob/5ceb2238d3685255cd517ca87fd7edae9ed88811/runtime/lua/vim/lsp.lua#L1610-L1628
Diffstat (limited to 'helix-term/src/commands')
0 files changed, 0 insertions, 0 deletions