aboutsummaryrefslogtreecommitdiff
path: root/helix-term/tests
diff options
context:
space:
mode:
authorMike Trinkala2024-03-02 14:05:58 +0000
committerGitHub2024-03-02 14:05:58 +0000
commit5bd007266a962a534bd722619821e998735b71e2 (patch)
treeb932cfb1b34ee6eb5f31b036d843f883e24823fc /helix-term/tests
parentd769fadde085169c26a850966a6d5d8da7cc1c12 (diff)
Fix panic when using join_selections_space (#9783)
Joining lines with Alt-J does not properly select the inserted spaces when the selection contains blank lines. In the worst case it panics with an out of bounds index. thread 'main' panicked at 'called `Result::unwrap()` on an `Err` value: Char index out of bounds: char index 11, Rope/RopeSlice char length 10' Steps to reproduce: * Create a new document ``` a b c d e ``` * % (Select all) * Alt-J (join and select the spaces)
Diffstat (limited to 'helix-term/tests')
-rw-r--r--helix-term/tests/test/commands.rs83
1 files changed, 83 insertions, 0 deletions
diff --git a/helix-term/tests/test/commands.rs b/helix-term/tests/test/commands.rs
index e52b142c..1172a798 100644
--- a/helix-term/tests/test/commands.rs
+++ b/helix-term/tests/test/commands.rs
@@ -526,3 +526,86 @@ async fn test_join_selections() -> anyhow::Result<()> {
Ok(())
}
+
+#[tokio::test(flavor = "multi_thread")]
+async fn test_join_selections_space() -> anyhow::Result<()> {
+ // join with empty lines panic
+ test((
+ platform_line(indoc! {"\
+ #[a
+
+ b
+
+ c
+
+ d
+
+ e|]#
+ "}),
+ "<A-J>",
+ platform_line(indoc! {"\
+ a#[ |]#b#( |)#c#( |)#d#( |)#e
+ "}),
+ ))
+ .await?;
+
+ // normal join
+ test((
+ platform_line(indoc! {"\
+ #[a|]#bc
+ def
+ "}),
+ "<A-J>",
+ platform_line(indoc! {"\
+ abc#[ |]#def
+ "}),
+ ))
+ .await?;
+
+ // join with empty line
+ test((
+ platform_line(indoc! {"\
+ #[a|]#bc
+
+ def
+ "}),
+ "<A-J>",
+ platform_line(indoc! {"\
+ #[a|]#bc
+ def
+ "}),
+ ))
+ .await?;
+
+ // join with additional space in non-empty line
+ test((
+ platform_line(indoc! {"\
+ #[a|]#bc
+
+ def
+ "}),
+ "<A-J><A-J>",
+ platform_line(indoc! {"\
+ abc#[ |]#def
+ "}),
+ ))
+ .await?;
+
+ // join with retained trailing spaces
+ test((
+ platform_line(indoc! {"\
+ #[aaa
+
+ bb
+
+ c |]#
+ "}),
+ "<A-J>",
+ platform_line(indoc! {"\
+ aaa #[ |]#bb #( |)#c
+ "}),
+ ))
+ .await?;
+
+ Ok(())
+}