diff options
| author | Pascal Kuthe | 2024-01-28 16:34:45 +0000 |
|---|---|---|
| committer | GitHub | 2024-01-28 16:34:45 +0000 |
| commit | 87a720c3a13ccc7245f5b0befc008db5bd039032 (patch) | |
| tree | e0e3f91c516a10d154cd01861e96ae0f50ea3cad /helix-view/src/document.rs | |
| parent | f5b67d9acb89ea54e7226111e3e4d8c3a008144b (diff) | |
make path changes LSP spec conform (#8949)
Currently, helix implements operations which change the paths of files
incorrectly and inconsistently. This PR ensures that we do the following
whenever a buffer is renamed (`:move` and workspace edits)
* always send did_open/did_close notifications
* send will_rename/did_rename requests correctly
* send them to all LSP servers not just those that are active for a
buffer
* also send these requests for paths that are not yet open in a buffer (if
triggered from workspace edit).
* only send these if the server registered interests in the path
* autodetect language, indent, line ending, ..
This PR also centralizes the infrastructure for path setting and
therefore `:w <path>` benefits from similar fixed (but without didRename)
Diffstat (limited to 'helix-view/src/document.rs')
| -rw-r--r-- | helix-view/src/document.rs | 3 |
1 files changed, 3 insertions, 0 deletions
diff --git a/helix-view/src/document.rs b/helix-view/src/document.rs index 88653948..33137c6c 100644 --- a/helix-view/src/document.rs +++ b/helix-view/src/document.rs @@ -1041,6 +1041,9 @@ impl Document { self.encoding } + /// sets the document path without sending events to various + /// observers (like LSP), in most cases `Editor::set_doc_path` + /// should be used instead pub fn set_path(&mut self, path: Option<&Path>) { let path = path.map(helix_stdx::path::canonicalize); |